third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp - Issue 2805633002: Count 'icon' attribute of MENUITEM element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp

Issue 2805633002: Count 'icon' attribute of MENUITEM element. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp b/third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp

index 09f029acb26e8808c5bbc13fe093258a9f7975e2..572632ea866f09c4a55864e78909173b722ada74 100644

--- a/third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp

@@ -19,4 +19,11 @@ HTMLUnknownElement::HTMLUnknownElement(const QualifiedName& tagName,

UseCounter::count(document, UseCounter::MenuItemElement);

}

+void HTMLUnknownElement::parseAttribute(

+ const AttributeModificationParams& params) {

+ if (params.name == HTMLNames::iconAttr && hasTagName(HTMLNames::menuitemTag))

+ UseCounter::count(document(), UseCounter::MenuItemElementIconAttribute);

+ HTMLElement::parseAttribute(params);

} // namespace blink