Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 2805533003: [build/android] Load/dump pickles directly form/to files (Closed)

Created:
3 years, 8 months ago by perezju
Modified:
3 years, 8 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[build/android] Load/dump pickles directly form/to files No need to build intermediate (possibly quite large) strings. This might also help with large objects failing to pickle. BUG=680935 Review-Url: https://codereview.chromium.org/2805533003 Cr-Commit-Position: refs/heads/master@{#462553} Committed: https://chromium.googlesource.com/chromium/src/+/be6dcf5eec3df0153f9e67b0b1a15cf4416144b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/local/device/local_device_perf_test_run.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/perf/perf_test_instance.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
perezju
3 years, 8 months ago (2017-04-06 15:08:09 UTC) #3
jbudorick
lgtm
3 years, 8 months ago (2017-04-06 15:17:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805533003/1
3 years, 8 months ago (2017-04-06 16:45:33 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 18:45:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be6dcf5eec3df0153f9e67b0b1a1...

Powered by Google App Engine
This is Rietveld 408576698