build/android/pylib/instrumentation/instrumentation_test_instance.py - Issue 2805533003: [build/android] Load/dump pickles directly form/to files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2805533003: [build/android] Load/dump pickles directly form/to files (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/instrumentation/instrumentation_test_instance.py

diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py

index 5261ff284b3c76c78404200be2a3bfff35074f25..d01e36eeeee8a84eba18096a487f0a75eb4ac678 100644

--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py

+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py

@@ -321,8 +321,8 @@ def _GetTestsFromPickle(pickle_path, jar_path):

raise TestListPickleException(

'%s newer than %s.' % (jar_path, pickle_path))

- with open(pickle_path, 'r') as pickle_file:

- pickle_data = pickle.loads(pickle_file.read())

+ with open(pickle_path, 'r') as f:

+ pickle_data = pickle.load(f)

jar_md5 = md5sum.CalculateHostMd5Sums(jar_path)[jar_path]

if pickle_data['VERSION'] != _PICKLE_FORMAT_VERSION:

« no previous file with comments | « no previous file | build/android/pylib/local/device/local_device_perf_test_run.py » ('j') | no next file with comments »