Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2805443004: Revert of Disable MediaStreamAudioTest.CallbackOnTrackInitialization on Mac. (Closed)

Created:
3 years, 8 months ago by foolip
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable MediaStreamAudioTest.CallbackOnTrackInitialization on Mac. (patchset #1 id:1 of https://codereview.chromium.org/2799663006/ ) Reason for revert: Whole test should be reverted: https://codereview.chromium.org/2803183002/ Original issue's description: > Disable MediaStreamAudioTest.CallbackOnTrackInitialization on Mac. > > Disabling the test, because it has been consistently failing > for the last 3 builds on Mac10.9 Tests (dbg). OTOH, note that > FindIt says that it cannot find the culprit CL and thinks that > the test is just flaky. In either case, disabling the test seems like > the right thing to do. > > BUG=709231 > TBR=hta@chromium.org > > Review-Url: https://codereview.chromium.org/2799663006 > Cr-Commit-Position: refs/heads/master@{#462701} > Committed: https://chromium.googlesource.com/chromium/src/+/e0f62aa119e65f04322c7d51b09c7e75dc2adc53 TBR=hta@chromium.org,lukasza@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=709231 Review-Url: https://codereview.chromium.org/2805443004 Cr-Commit-Position: refs/heads/master@{#462793} Committed: https://chromium.googlesource.com/chromium/src/+/2c6775c0307883f2c1cd1abdc1b9eaa7a2897164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M content/renderer/media/media_stream_audio_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
foolip
Created Revert of Disable MediaStreamAudioTest.CallbackOnTrackInitialization on Mac.
3 years, 8 months ago (2017-04-07 06:33:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805443004/1
3 years, 8 months ago (2017-04-07 06:34:06 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 06:36:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c6775c0307883f2c1cd1abdc1b9...

Powered by Google App Engine
This is Rietveld 408576698