Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2799663006: Disable MediaStreamAudioTest.CallbackOnTrackInitialization on Mac. (Closed)

Created:
3 years, 8 months ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
Reviewers:
hta - Chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable MediaStreamAudioTest.CallbackOnTrackInitialization on Mac. Disabling the test, because it has been consistently failing for the last 3 builds on Mac10.9 Tests (dbg). OTOH, note that FindIt says that it cannot find the culprit CL and thinks that the test is just flaky. In either case, disabling the test seems like the right thing to do. BUG=709231 TBR=hta@chromium.org Review-Url: https://codereview.chromium.org/2799663006 Cr-Commit-Position: refs/heads/master@{#462701} Committed: https://chromium.googlesource.com/chromium/src/+/e0f62aa119e65f04322c7d51b09c7e75dc2adc53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/renderer/media/media_stream_audio_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Łukasz Anforowicz
hta@, can you PTAL? I am a bit hesitant to TBR this CL, but 1) ...
3 years, 8 months ago (2017-04-06 23:23:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799663006/1
3 years, 8 months ago (2017-04-06 23:39:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e0f62aa119e65f04322c7d51b09c7e75dc2adc53
3 years, 8 months ago (2017-04-07 00:16:51 UTC) #11
foolip
3 years, 8 months ago (2017-04-07 06:33:56 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2805443004/ by foolip@chromium.org.

The reason for reverting is: Whole test should be reverted:
https://codereview.chromium.org/2803183002/.

Powered by Google App Engine
This is Rietveld 408576698