net/cert/internal/path_builder_verify_certificate_chain_unittest.cc - Issue 2805213004: Refactor how net/data/verify_certificate_chain_unittest/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

Issue 2805213004: Refactor how net/data/verify_certificate_chain_unittest/* (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

diff --git a/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc b/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

index 09fda9c96cc614c83e4955a57c4d3cd7c90eab84..9d7168e82b534b425b42316db5916c3437bdd73c 100644

--- a/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

+++ b/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

@@ -49,7 +49,7 @@ class PathBuilderDelegate {

path_builder.AddCertIssuerSource(&intermediate_cert_issuer_source);

path_builder.Run();

- EXPECT_EQ(test.expected_result, result.HasValidPath());

+ EXPECT_EQ(test.expected_errors.empty(), result.HasValidPath());

mattm 2017/05/02 06:43:46 This is fine, but I wonder if maybe it should have

eroman 2017/05/02 19:20:23 I have tried to address this by adding a helper Ha

}

};

« no previous file with comments | « net/cert/internal/path_builder_unittest.cc ('k') | net/cert/internal/test_helpers.h » ('j') | net/cert/internal/test_helpers.cc » ('J')