Refactor how net/data/verify_certificate_chain_unittest/*

net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/path_builder.h"
 
 #include "net/cert/internal/cert_issuer_source_static.h"
 #include "net/cert/internal/signature_policy.h"
 #include "net/cert/internal/trust_store_in_memory.h"
 #include "net/cert/internal/verify_certificate_chain_typed_unittest.h"
@@ skipping 31 matching lines @@
       intermediate_cert_issuer_source.AddCert(test.chain[i]);
 
     CertPathBuilder::Result result;
     // First cert in the |chain| is the target.
     CertPathBuilder path_builder(test.chain.front(), &trust_store,
                                  &signature_policy, test.time, test.key_purpose,
                                  &result);
     path_builder.AddCertIssuerSource(&intermediate_cert_issuer_source);
 
     path_builder.Run();
-    EXPECT_EQ(test.expected_result, result.HasValidPath());
+    EXPECT_EQ(test.expected_errors.empty(), result.HasValidPath());

[mattm, 2017/05/02 06:43:46]

This is fine, but I wonder if maybe it should have a comment?

[eroman, 2017/05/02 19:20:23]

I have tried to address this by adding a helper HasHighSeverityErrors().

   }
 };
 
 }  // namespace
 
 INSTANTIATE_TYPED_TEST_CASE_P(PathBuilder,
                               VerifyCertificateChainSingleRootTest,
                               PathBuilderDelegate);
 
 }  // namespace net