Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: net/cert/internal/test_helpers.h

Issue 2805213004: Refactor how net/data/verify_certificate_chain_unittest/* (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/test_helpers.h
diff --git a/net/cert/internal/test_helpers.h b/net/cert/internal/test_helpers.h
index 0ba8938257fbb79c53431d2927ba7bc42e919a67..3779e1eeb9b4c84ef3c1478e88bb1b5d02812ff9 100644
--- a/net/cert/internal/test_helpers.h
+++ b/net/cert/internal/test_helpers.h
@@ -11,6 +11,7 @@
#include <string>
#include <vector>
+#include "base/files/file_path.h"
#include "net/cert/internal/parsed_certificate.h"
#include "net/cert/internal/trust_store.h"
#include "net/cert/internal/verify_certificate_chain.h"
@@ -95,9 +96,6 @@ struct VerifyCertChainTest {
// The Key Purpose to use when verifying the chain.
KeyPurpose key_purpose = KeyPurpose::ANY_EKU;
- // The expected result from verification.
- bool expected_result = false;
-
// The expected errors from verification (as a string).
std::string expected_errors;
};
@@ -105,9 +103,13 @@ struct VerifyCertChainTest {
// Reads a test case from |file_path_ascii| (which is relative to //src).
// Generally |file_path_ascii| will start with:
// net/data/verify_certificate_chain_unittest/
-void ReadVerifyCertChainTestFromFile(const std::string& file_path_ascii,
+bool ReadVerifyCertChainTestFromFile(const std::string& file_path_ascii,
VerifyCertChainTest* test);
+// Reads a certificate chain from |file_path_ascii|
+bool ReadCertChainFromFile(const std::string& file_path_ascii,
+ ParsedCertificateList* chain);
+
// Reads a data file relative to the src root directory.
std::string ReadTestFileToString(const std::string& file_path_ascii);

Powered by Google App Engine
This is Rietveld 408576698