Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2805173003: Fix autofill popup controller key press callback registration (Closed)

Created:
3 years, 8 months ago by vabr (Chromium)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix autofill popup controller key press callback registration Currently, PopupControllerCommon::RegisterKeyPressCallback registers its key press handler via RenderView. This results in broken key handling with site isolation. The fix is to use the focused RenderFrame itself. BUG=688848 Review-Url: https://codereview.chromium.org/2762233004 Cr-Commit-Position: refs/heads/master@{#462381} (cherry picked from commit 6d61e0d262cc02641e963c1fc4fccd374555fad7) Review-Url: https://codereview.chromium.org/2805173003 . Cr-Commit-Position: refs/branch-heads/3029@{#633} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/1c23dd84142131a6090f9032ddd0776af68e0dc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -142 lines) Patch
M chrome/browser/autofill/autofill_interactive_uitest.cc View 6 chunks +88 lines, -7 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 6 chunks +15 lines, -19 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.h View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 8 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/popup_controller_common.h View 1 chunk +8 lines, -50 lines 0 comments Download
M chrome/browser/ui/autofill/popup_controller_common.cc View 1 chunk +5 lines, -35 lines 0 comments Download
A chrome/test/data/autofill/cross_origin_iframe.html View 1 chunk +11 lines, -0 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver.h View 4 chunks +16 lines, -1 line 0 comments Download
M components/autofill/content/browser/content_autofill_driver.cc View 3 chunks +27 lines, -0 lines 0 comments Download
A components/autofill/content/browser/key_press_handler_manager.h View 1 chunk +47 lines, -0 lines 0 comments Download
A components/autofill/content/browser/key_press_handler_manager.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A components/autofill/content/browser/key_press_handler_manager_unittest.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_popup_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_manager_driver.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/stub_password_manager_driver.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/stub_password_manager_driver.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
3 years, 8 months ago (2017-04-07 21:24:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c23dd84142131a6090f9032ddd0776af68e0dc6.

Powered by Google App Engine
This is Rietveld 408576698