Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.h

Issue 2805173003: Fix autofill popup controller key press callback registration (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
index 9ead2d58985c644e7486c4e6a99823c7364a3f22..aebd565d1c2c9b497c1be602f53e5ea389b47c9d 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
@@ -71,11 +71,6 @@ class PasswordGenerationPopupControllerImpl
// Hides the popup and destroys |this|.
void HideAndDestroy();
- // Accessors.
- content::WebContents* web_contents() {
- return controller_common_.web_contents();
- }
-
protected:
PasswordGenerationPopupControllerImpl(
const gfx::RectF& bounds,
@@ -141,8 +136,8 @@ class PasswordGenerationPopupControllerImpl
// Controls how passwords are generated.
std::unique_ptr<PasswordGenerator> generator_;
- // Contains common popup functionality.
- PopupControllerCommon controller_common_;
+ // Contains common popup data.
+ const PopupControllerCommon controller_common_;
// Help text and the range in the text that corresponds to the saved passwords
// link.
@@ -160,6 +155,8 @@ class PasswordGenerationPopupControllerImpl
PopupViewCommon view_common_;
+ content::WebContents* const web_contents_;
+
base::WeakPtrFactory<PasswordGenerationPopupControllerImpl> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(PasswordGenerationPopupControllerImpl);

Powered by Google App Engine
This is Rietveld 408576698