Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2805043003: Requiring Get prefix for 5 more methods (to avoid conflicts after Blink rename). (Closed)

Created:
3 years, 8 months ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, nasko
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Requiring Get prefix for 5 more methods (to avoid conflicts after Blink rename). This CL adds a few more methods that cause name collisions when Blink is rewritten to match Chromium style: - accumulatorMap - eventTargetDataMap - heapObjectSet - qualifiedNameCache - selectorTextCache BUG=582312 Review-Url: https://codereview.chromium.org/2805043003 Cr-Commit-Position: refs/heads/master@{#462627} Committed: https://chromium.googlesource.com/chromium/src/+/0f822b53c05998de526f73fc5e4187650dcf0336

Patch Set 1 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 5 chunks +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Łukasz Anforowicz
dcheng@, can you PTAL? This CL adds exceptions for method names that nasko@ pointed out ...
3 years, 8 months ago (2017-04-06 20:08:13 UTC) #2
dcheng
LGTM Any idea what's going on with Document?
3 years, 8 months ago (2017-04-06 20:22:08 UTC) #3
Łukasz Anforowicz
On 2017/04/06 20:22:08, dcheng wrote: > LGTM Thanks. > Any idea what's going on with ...
3 years, 8 months ago (2017-04-06 20:29:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805043003/20001
3 years, 8 months ago (2017-04-06 20:30:48 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 21:27:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f822b53c05998de526f73fc5e41...

Powered by Google App Engine
This is Rietveld 408576698