Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2799803003: Requiring Get prefix for 13 more methods (to avoid conflicts after Blink rename) (Closed)

Created:
3 years, 8 months ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, nasko
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Requiring Get prefix for 13 more methods (to avoid conflicts after Blink rename) This CL adds a few more methods that cause name collisions when Blink is rewritten to match Chromium style: - attrNodeList - constructionStack - counterMaps - harfBuzzFontCache - infoMap - intervalArena - originAccessMap - presentationAttributeCache - selectionVisualRectMap - styleSharingList - weakHeapObjectSet - worldMap - wrapperTypeInfo BUG=582312 Review-Url: https://codereview.chromium.org/2799803003 Cr-Commit-Position: refs/heads/master@{#462640} Committed: https://chromium.googlesource.com/chromium/src/+/7ce718fb7d7e6cfb17735b573458d578feb02e7e

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -92 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 1 chunk +102 lines, -92 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Łukasz Anforowicz
dcheng@, can you PTAL at another set of methods that need a Get prefix? I've ...
3 years, 8 months ago (2017-04-06 20:41:16 UTC) #2
dcheng
LGTM
3 years, 8 months ago (2017-04-06 20:46:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799803003/20001
3 years, 8 months ago (2017-04-06 21:34:22 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 22:03:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ce718fb7d7e6cfb17735b573458...

Powered by Google App Engine
This is Rietveld 408576698