Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2805013002: Add spec links for WebGL IDL files (Closed)

Created:
3 years, 8 months ago by foolip
Modified:
3 years, 8 months ago
CC:
chromium-reviews, haraken, blink-reviews, Kai Ninomiya, Zhenyao Mo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add spec links for WebGL IDL files R=kbr@chromium.org BUG=706559 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2805013002 Cr-Commit-Position: refs/heads/master@{#462774} Committed: https://chromium.googlesource.com/chromium/src/+/be1feafb3ea0da9a6a3b7f48320470fb61487fc6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webgl/ANGLEInstancedArrays.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTBlendMinMax.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTColorBufferFloat.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTFragDepth.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTShaderTextureLOD.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTTextureFilterAnisotropic.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTsRGB.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/OESElementIndexUint.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/OESStandardDerivatives.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/OESTextureFloat.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/OESTextureFloatLinear.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/OESTextureHalfFloat.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/OESTextureHalfFloatLinear.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/OESVertexArrayObject.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 chunk +2 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLBuffer.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureASTC.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureATC.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureETC.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureETC1.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLCompressedTexturePVRTC.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureS3TC.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureS3TCsRGB.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDebugRendererInfo.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDepthTexture.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLGetBufferSubDataAsync.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLLoseContext.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLProgram.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLQuery.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSampler.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLShader.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLShaderPrecisionFormat.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSync.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTexture.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTransformFeedback.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLUniformLocation.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectOES.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
foolip
3 years, 8 months ago (2017-04-06 13:30:30 UTC) #1
Ken Russell (switch to Gerrit)
Thanks. LGTM. I didn't check all the links though. One comment. https://codereview.chromium.org/2805013002/diff/1/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl (right): ...
3 years, 8 months ago (2017-04-06 20:29:25 UTC) #7
foolip
https://codereview.chromium.org/2805013002/diff/1/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl (right): https://codereview.chromium.org/2805013002/diff/1/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl#newcode5 third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl:5: // https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7 On 2017/04/06 20:29:24, Ken Russell wrote: > ...
3 years, 8 months ago (2017-04-07 05:08:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805013002/1
3 years, 8 months ago (2017-04-07 05:09:04 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 05:39:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be1feafb3ea0da9a6a3b7f483204...

Powered by Google App Engine
This is Rietveld 408576698