Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2804863002: [wasm] Remove max_mem_pages from WasmCompiledModule (Closed)

Created:
3 years, 8 months ago by Mircea Trofin
Modified:
3 years, 8 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove max_mem_pages from WasmCompiledModule It's not necessary at finalization, and may be obtained from the shared, native object. BUG= Review-Url: https://codereview.chromium.org/2804863002 Cr-Commit-Position: refs/heads/master@{#44441} Committed: https://chromium.googlesource.com/v8/v8/+/8b380d518eed17b1475b9f4750349b482f418c69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/wasm/wasm-objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/wasm/wasm-objects.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Mircea Trofin
As Andreas observed - we don't need max_mem_pages stored on the WasmCompiledModule.
3 years, 8 months ago (2017-04-05 20:10:20 UTC) #5
ahaas
lgtm
3 years, 8 months ago (2017-04-06 07:44:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804863002/1
3 years, 8 months ago (2017-04-06 12:53:16 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 12:54:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8b380d518eed17b1475b9f4750349b482f4...

Powered by Google App Engine
This is Rietveld 408576698