Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Unified Diff: src/wasm/wasm-objects.cc

Issue 2804863002: [wasm] Remove max_mem_pages from WasmCompiledModule (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-objects.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-objects.cc
diff --git a/src/wasm/wasm-objects.cc b/src/wasm/wasm-objects.cc
index 1e46170c26329bf3dbf91f6328e6e733fe92fca7..6655a29e6553043635e7125898c211b8e12bcca8 100644
--- a/src/wasm/wasm-objects.cc
+++ b/src/wasm/wasm-objects.cc
@@ -647,7 +647,7 @@ uint32_t WasmInstanceObject::GetMaxMemoryPages() {
if (maximum < FLAG_wasm_max_mem_pages) return maximum;
}
}
- uint32_t compiled_max_pages = compiled_module()->max_mem_pages();
+ uint32_t compiled_max_pages = compiled_module()->module()->max_mem_pages;
Isolate* isolate = GetIsolate();
auto* histogram = (compiled_module()->module()->is_wasm()
? isolate->counters()->wasm_wasm_max_mem_pages_count()
@@ -969,11 +969,10 @@ Handle<WasmCompiledModule> WasmCompiledModule::New(
maybe_empty_function_tables.ToHandleChecked());
}
// TODO(mtrofin): we copy these because the order of finalization isn't
- // reliable, and we need some of these at Reset (which is called at
+ // reliable, and we need these at Reset (which is called at
// finalization). If the order were reliable, and top-down, we could instead
// just get them from shared().
compiled_module->set_min_mem_pages(shared->module()->min_mem_pages);
- compiled_module->set_max_mem_pages(shared->module()->max_mem_pages);
compiled_module->set_num_imported_functions(
shared->module()->num_imported_functions);
return compiled_module;
« no previous file with comments | « src/wasm/wasm-objects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698