third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2804813002: Hide popups when handling mouse down, mouse wheel, or gesture tap in a WebFrameWidget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2804813002: Hide popups when handling mouse down, mouse wheel, or gesture tap in a WebFrameWidget (Closed)

Patch Set: (Try to) Dismiss popup on scroll and gesture tap Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index f6586700e856de30197df47465adfd35b72ab985..122810cd54a5c086edc125cbdec7b48901195ab2 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -170,7 +170,6 @@

#include "web/WebInputEventConversion.h"

#include "web/WebInputMethodControllerImpl.h"

#include "web/WebLocalFrameImpl.h"

-#include "web/WebPagePopupImpl.h"

#include "web/WebPluginContainerImpl.h"

#include "web/WebRemoteFrameImpl.h"

#include "web/WebSettingsImpl.h"

@@ -2520,7 +2519,7 @@ WebColor WebViewImpl::backgroundColor() const {

return view->documentBackgroundColor().rgb();

}

-WebPagePopup* WebViewImpl::pagePopup() const {

+WebPagePopupImpl* WebViewImpl::pagePopup() const {

return m_pagePopup.get();

}