Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2804813002: Hide popups when handling mouse down, mouse wheel, or gesture tap in a WebFrameWidget (Closed)
Patch Set: (Try to) Dismiss popup on scroll and gesture tap Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 #include "web/PrerendererClientImpl.h" 163 #include "web/PrerendererClientImpl.h"
164 #include "web/ResizeViewportAnchor.h" 164 #include "web/ResizeViewportAnchor.h"
165 #include "web/RotationViewportAnchor.h" 165 #include "web/RotationViewportAnchor.h"
166 #include "web/SpeechRecognitionClientProxy.h" 166 #include "web/SpeechRecognitionClientProxy.h"
167 #include "web/StorageQuotaClientImpl.h" 167 #include "web/StorageQuotaClientImpl.h"
168 #include "web/ValidationMessageClientImpl.h" 168 #include "web/ValidationMessageClientImpl.h"
169 #include "web/WebDevToolsAgentImpl.h" 169 #include "web/WebDevToolsAgentImpl.h"
170 #include "web/WebInputEventConversion.h" 170 #include "web/WebInputEventConversion.h"
171 #include "web/WebInputMethodControllerImpl.h" 171 #include "web/WebInputMethodControllerImpl.h"
172 #include "web/WebLocalFrameImpl.h" 172 #include "web/WebLocalFrameImpl.h"
173 #include "web/WebPagePopupImpl.h"
174 #include "web/WebPluginContainerImpl.h" 173 #include "web/WebPluginContainerImpl.h"
175 #include "web/WebRemoteFrameImpl.h" 174 #include "web/WebRemoteFrameImpl.h"
176 #include "web/WebSettingsImpl.h" 175 #include "web/WebSettingsImpl.h"
177 #include "wtf/AutoReset.h" 176 #include "wtf/AutoReset.h"
178 #include "wtf/CurrentTime.h" 177 #include "wtf/CurrentTime.h"
179 #include "wtf/PtrUtil.h" 178 #include "wtf/PtrUtil.h"
180 #include "wtf/RefPtr.h" 179 #include "wtf/RefPtr.h"
181 180
182 #if USE(DEFAULT_RENDER_THEME) 181 #if USE(DEFAULT_RENDER_THEME)
183 #include "core/layout/LayoutThemeDefault.h" 182 #include "core/layout/LayoutThemeDefault.h"
(...skipping 2329 matching lines...) Expand 10 before | Expand all | Expand 10 after
2513 if (!m_page->mainFrame()) 2512 if (!m_page->mainFrame())
2514 return baseBackgroundColor().rgb(); 2513 return baseBackgroundColor().rgb();
2515 if (!m_page->mainFrame()->isLocalFrame()) 2514 if (!m_page->mainFrame()->isLocalFrame())
2516 return baseBackgroundColor().rgb(); 2515 return baseBackgroundColor().rgb();
2517 FrameView* view = m_page->deprecatedLocalMainFrame()->view(); 2516 FrameView* view = m_page->deprecatedLocalMainFrame()->view();
2518 if (!view) 2517 if (!view)
2519 return baseBackgroundColor().rgb(); 2518 return baseBackgroundColor().rgb();
2520 return view->documentBackgroundColor().rgb(); 2519 return view->documentBackgroundColor().rgb();
2521 } 2520 }
2522 2521
2523 WebPagePopup* WebViewImpl::pagePopup() const { 2522 WebPagePopupImpl* WebViewImpl::pagePopup() const {
2524 return m_pagePopup.get(); 2523 return m_pagePopup.get();
2525 } 2524 }
2526 2525
2527 // TODO(ekaramad):This method is almost duplicated in WebFrameWidgetImpl as 2526 // TODO(ekaramad):This method is almost duplicated in WebFrameWidgetImpl as
2528 // well. This code needs to be refactored (http://crbug.com/629721). 2527 // well. This code needs to be refactored (http://crbug.com/629721).
2529 WebRange WebViewImpl::caretOrSelectionRange() { 2528 WebRange WebViewImpl::caretOrSelectionRange() {
2530 const LocalFrame* focused = focusedLocalFrameInWidget(); 2529 const LocalFrame* focused = focusedLocalFrameInWidget();
2531 if (!focused) 2530 if (!focused)
2532 return WebRange(); 2531 return WebRange();
2533 2532
(...skipping 1698 matching lines...) Expand 10 before | Expand all | Expand 10 after
4232 if (focusedFrame->localFrameRoot() != mainFrameImpl()->frame()) 4231 if (focusedFrame->localFrameRoot() != mainFrameImpl()->frame())
4233 return nullptr; 4232 return nullptr;
4234 return focusedFrame; 4233 return focusedFrame;
4235 } 4234 }
4236 4235
4237 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const { 4236 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const {
4238 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr; 4237 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr;
4239 } 4238 }
4240 4239
4241 } // namespace blink 4240 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698