Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2804813002: Hide popups when handling mouse down, mouse wheel, or gesture tap in a WebFrameWidget (Closed)
Patch Set: (Try to) Dismiss popup on scroll and gesture tap Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 8ca329839640be50f7a666bbf12288d45c0d442e..e25567dc2d6840f9e02fac3cf6134fef1e55aaab 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -64,6 +64,7 @@
#include "web/SpellCheckerClientImpl.h"
#include "web/StorageClientImpl.h"
#include "web/WebExport.h"
+#include "web/WebPagePopupImpl.h"
#include "wtf/Compiler.h"
#include "wtf/HashSet.h"
#include "wtf/RefCounted.h"
@@ -90,7 +91,6 @@ class WebLayerTreeView;
class WebLocalFrame;
class WebLocalFrameImpl;
class CompositorMutatorImpl;
-class WebPagePopupImpl;
class WebPlugin;
class WebRemoteFrame;
class WebSettingsImpl;
@@ -156,7 +156,7 @@ class WEB_EXPORT WebViewImpl final
void setFocus(bool enable) override;
WebRange compositionRange() override;
WebColor backgroundColor() const override;
- WebPagePopup* pagePopup() const override;
+ WebPagePopupImpl* pagePopup() const override;
bool selectionBounds(WebRect& anchor, WebRect& focus) const override;
bool selectionTextDirection(WebTextDirection& start,
WebTextDirection& end) const override;
@@ -518,6 +518,10 @@ class WEB_EXPORT WebViewImpl final
// root.
WebInputMethodControllerImpl* getActiveWebInputMethodController() const;
+ void setLastHiddenPagePopup(WebPagePopupImpl* pagePopup) {
+ m_lastHiddenPagePopup = pagePopup;
+ }
+
private:
InspectorOverlay* inspectorOverlay();

Powered by Google App Engine
This is Rietveld 408576698