Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2804633005: Allow building with is_clang=false, use_sysroot=true (Closed)

Created:
3 years, 8 months ago by Tom (Use chromium acct)
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Sam Clegg
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow building with is_clang=false, use_sysroot=true Building with the wheezy sysroot and is_clang=false results in errors like this: ../../base/process/process_iterator.h:12:16: fatal error: list: No such file or directory #include <list> [1] added a restriction that use_sysroot must be false when building with is_clang=false. However, as of [2], the wheezy sysroot has been removed, and these compilation errors are not present on the Jessie sysroot. This CL removes the restriction added by [1]. [1] https://codereview.chromium.org/1476923005 [2] https://codereview.chromium.org/2597523003 BUG=575778 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2804633005 Cr-Commit-Position: refs/heads/master@{#462343} Committed: https://chromium.googlesource.com/chromium/src/+/c2c8a4d94797d67f76e061be40cfed0378eccd81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/config/sysroot.gni View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom (Use chromium acct)
dpranke@ ptal
3 years, 8 months ago (2017-04-05 21:52:31 UTC) #1
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-06 00:58:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804633005/1
3 years, 8 months ago (2017-04-06 03:03:32 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 03:32:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2c8a4d94797d67f76e061be40cf...

Powered by Google App Engine
This is Rietveld 408576698