Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/sysroot.gni

Issue 2804633005: Allow building with is_clang=false, use_sysroot=true (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sysroot.gni
diff --git a/build/config/sysroot.gni b/build/config/sysroot.gni
index 60fc290af5ee8d9cd5348b829fb8078bc6283476..63e3c137255a749f47c1eeb20ba7231bb1d974ec 100644
--- a/build/config/sysroot.gni
+++ b/build/config/sysroot.gni
@@ -63,12 +63,6 @@ if (is_linux && target_sysroot_dir != "") {
}
if (sysroot != "") {
- # Our sysroot images only contains gcc 4.6 headers, but chromium requires
- # gcc 4.9. Clang is able to detect and work with the 4.6 headers while
- # gcc is not. This check can be removed if we ever update to a more modern
- # sysroot.
- assert(is_clang, "sysroot images require clang (try use_sysroot=false)")
-
_script_arch = current_cpu
if (_script_arch == "x86") {
_script_arch = "i386"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698