Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2804633004: Convert Oscillator tests to new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Oscillator tests to new Audit Manually convert tests to use new Audit BUG=704967 TEST= Oscillator/osc-low-freq.html Oscillator/osc-negative-freq.html Oscillator/oscillator-basic.html Oscillator/oscillator-late-start.html Review-Url: https://codereview.chromium.org/2804633004 Cr-Commit-Position: refs/heads/master@{#465666} Committed: https://chromium.googlesource.com/chromium/src/+/cc2c20104f7d15934c0ab44edf91b67608037c37

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -75 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq.html View 4 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-negative-freq.html View 1 5 chunks +29 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-basic.html View 2 chunks +31 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Raymond Toy
PTAL. I think this is pretty straightforward and trivial
3 years, 8 months ago (2017-04-12 23:11:24 UTC) #2
hongchan
Sorry that I missed this. lgtm with nit https://codereview.chromium.org/2804633004/diff/1/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-negative-freq.html File third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-negative-freq.html (right): https://codereview.chromium.org/2804633004/diff/1/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-negative-freq.html#newcode189 third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-negative-freq.html:189: .beCloseToArray(zero, ...
3 years, 8 months ago (2017-04-19 15:45:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804633004/20001
3 years, 8 months ago (2017-04-19 16:40:46 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 17:55:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cc2c20104f7d15934c0ab44edf91...

Powered by Google App Engine
This is Rietveld 408576698