third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq.html - Issue 2804633004: Convert Oscillator tests to new Audit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq.html

Issue 2804633004: Convert Oscillator tests to new Audit (Closed)

Patch Set: Address review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq.html b/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq.html

index 5a1e0d24fcb77675f862cc1a4c90678f07958cfc..46d33147e204ed084db251da561b63c7d2f7c437 100644

--- a/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq.html

+++ b/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq.html

@@ -5,7 +5,7 @@

- <script src="../resources/audio-testing.js"></script>

+ <script src="../resources/audit.js"></script>

</head>

<body>

@@ -34,7 +34,7 @@

var audit = Audit.createTaskRunner();

// Compute the SNR between the actual result and expected cosine wave

- function checkCosineResult(result, freq, sampleRate) {

+ function checkCosineResult(should, result, freq, sampleRate) {

var signal = 0;

var noise = 0;

var omega = 2 * Math.PI * freq / sampleRate;

@@ -50,13 +50,11 @@

var snr = 10 * Math.log10(signal / noise);

- Should("SNR of " + desiredFrequencyHz + " Hz sine wave", snr, {

- brief: true

- }).beGreaterThanOrEqualTo(snrThreshold);

- testPassed("PeriodicWave coefficients that must be ignored were correctly ignored.");

+ should(snr, "SNR of " + desiredFrequencyHz + " Hz sine wave")

+ .beGreaterThanOrEqualTo(snrThreshold);

}

- function runTest() {

+ audit.define("low-freq-oscillator", (task, should) => {

context = new OfflineAudioContext(1, sampleRate, sampleRate);

osc = context.createOscillator();

@@ -76,11 +74,12 @@

osc.connect(context.destination);

osc.start();

context.startRendering().then(function (buffer) {

- checkCosineResult(buffer, desiredFrequencyHz, sampleRate);

- });

- };

+ checkCosineResult(should, buffer, desiredFrequencyHz, sampleRate);

+ })

+ .then(() => task.done());

+ });

- runTest();

+ audit.run();

</script>

</body>

</html>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-negative-freq.html » ('j') | no next file with comments »