Issue 2804613003: Make lines and columns one-based in SourceLocation.

Issue 2804613003: Make lines and columns one-based in SourceLocation. (Closed)

Created:
3 years, 8 months ago by ahe

Modified:
3 years, 8 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Visibility:
Public.

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -49 lines)			Patch
M	pkg/compiler/lib/src/io/position_information.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/io/source_information.dart	View	5 chunks	+12 lines, -34 lines	0 comments	Download
M	pkg/compiler/lib/src/io/source_map_builder.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/io/start_end_information.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/sourcemaps/sourcemap_html_helper.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 7 (4 generated)

ahe

3 years, 8 months ago (2017-04-05 13:19:13 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:40001) manually as
a8d08eaf4b916c76d8d3668405e323d764077525 (presubmit successful).