tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart - Issue 2804613003: Make lines and columns one-based in SourceLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart

Issue 2804613003: Make lines and columns one-based in SourceLocation. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart

diff --git a/tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart b/tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart

index 244b6c9bd3ff46c4661727f90ed091fb71bb85e8..a0849efe778bba003cddb99260645ca610f339b2 100644

--- a/tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart

+++ b/tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart

@@ -503,8 +503,8 @@ class CodePointComputer extends TraceListener {

return sourceLocation.shortText;

}

return sourceFile.kernelSource

- .getTextLine(sourceLocation.line + 1)

- .substring(sourceLocation.column)

+ .getTextLine(sourceLocation.line)

+ .substring(sourceLocation.column - 1)

.trim();

}