Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: pkg/compiler/lib/src/io/start_end_information.dart

Issue 2804613003: Make lines and columns one-based in SourceLocation. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/io/start_end_information.dart
diff --git a/pkg/compiler/lib/src/io/start_end_information.dart b/pkg/compiler/lib/src/io/start_end_information.dart
index 3840b77b93eb8eba0117ebd46e224d7959281994..8456cd709fac47aec52dd4172e2e13438d839ba1 100644
--- a/pkg/compiler/lib/src/io/start_end_information.dart
+++ b/pkg/compiler/lib/src/io/start_end_information.dart
@@ -91,10 +91,9 @@ class StartEndSourceInformation extends SourceInformation {
String _computeText(String uriText) {
StringBuffer sb = new StringBuffer();
sb.write('$uriText:');
- // Use 1-based line/startPosition info to match usual dart tool output.
- sb.write('[${startPosition.line + 1},${startPosition.column + 1}]');
+ sb.write('[${startPosition.line},${startPosition.column}]');
if (endPosition != null) {
- sb.write('-[${endPosition.line + 1},${endPosition.column + 1}]');
+ sb.write('-[${endPosition.line},${endPosition.column}]');
}
return sb.toString();
}
« no previous file with comments | « pkg/compiler/lib/src/io/source_map_builder.dart ('k') | tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698