Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2804593005: Revert of [profiler] reduce incorrectly unaccounted ticks. (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Jarin, Camillo Bruni, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [profiler] reduce incorrectly unaccounted ticks. (patchset #4 id:60001 of https://codereview.chromium.org/2799603005/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/8247/steps/Check%20%28flakes%29/logs/CollectOptimizedTople.. Original issue's description: > [profiler] reduce incorrectly unaccounted ticks. > > No longer invalidate the tick sample if there is no JS frame or only one > non-interpreted JS frame on the stack. > > R=jarin@chromium.org > > Review-Url: https://codereview.chromium.org/2799603005 > Cr-Commit-Position: refs/heads/master@{#44465} > Committed: https://chromium.googlesource.com/v8/v8/+/57bef9a1e2621555f70b9258593ae4a4235307ef TBR=jarin@chromium.org,cbruni@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2804593005 Cr-Commit-Position: refs/heads/master@{#44469} Committed: https://chromium.googlesource.com/v8/v8/+/fae3f6bf4476b80b6f02167c51cacea57420cb1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -47 lines) Patch
M src/profiler/tick-sample.cc View 1 chunk +6 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jgruber
Created Revert of [profiler] reduce incorrectly unaccounted ticks.
3 years, 8 months ago (2017-04-07 08:23:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804593005/1
3 years, 8 months ago (2017-04-07 08:23:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/fae3f6bf4476b80b6f02167c51cacea57420cb1a
3 years, 8 months ago (2017-04-07 08:23:48 UTC) #6
jgruber
3 years, 8 months ago (2017-04-07 08:24:03 UTC) #7
Message was sent while issue was closed.
On 2017/04/07 08:23:28, jgruber wrote:
> Created Revert of [profiler] reduce incorrectly unaccounted ticks.

https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...

Powered by Google App Engine
This is Rietveld 408576698