Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2799603005:
[profiler] reduce incorrectly unaccounted ticks. (Closed)
Description[profiler] reduce incorrectly unaccounted ticks.
No longer invalidate the tick sample if there is no JS frame or only one
non-interpreted JS frame on the stack.
R=jarin@chromium.org
Review-Url: https://codereview.chromium.org/2799603005
Cr-Original-Commit-Position: refs/heads/master@{#44465}
Committed: https://chromium.googlesource.com/v8/v8/+/57bef9a1e2621555f70b9258593ae4a4235307ef
Review-Url: https://codereview.chromium.org/2799603005
Cr-Commit-Position: refs/heads/master@{#44478}
Committed: https://chromium.googlesource.com/v8/v8/+/818c6d0ba9e92e3bb0557fabaad886f7cfd9ea8a
Patch Set 1 #Patch Set 2 : fix comment #Patch Set 3 : reduce loop count #Patch Set 4 : blacklist arm64 #Patch Set 5 : remove test #
Messages
Total messages: 27 (17 generated)
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
cbruni@chromium.org changed reviewers: + cbruni@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org Link to the patchset: https://codereview.chromium.org/2799603005/#ps40001 (title: "reduce loop count")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)
lgtm. Thanks!
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org, cbruni@chromium.org Link to the patchset: https://codereview.chromium.org/2799603005/#ps60001 (title: "blacklist arm64")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491539738156020,
"parent_rev": "12ab9484ee6ae479ec1f929b943bd63d5ef80f3c", "commit_rev":
"57bef9a1e2621555f70b9258593ae4a4235307ef"}
Message was sent while issue was closed.
Description was changed from ========== [profiler] reduce incorrectly unaccounted ticks. No longer invalidate the tick sample if there is no JS frame or only one non-interpreted JS frame on the stack. R=jarin@chromium.org ========== to ========== [profiler] reduce incorrectly unaccounted ticks. No longer invalidate the tick sample if there is no JS frame or only one non-interpreted JS frame on the stack. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2799603005 Cr-Commit-Position: refs/heads/master@{#44465} Committed: https://chromium.googlesource.com/v8/v8/+/57bef9a1e2621555f70b9258593ae4a4235... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/v8/v8/+/57bef9a1e2621555f70b9258593ae4a4235...
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2804593005/ by jgruber@chromium.org. The reason for reverting is: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds....
Message was sent while issue was closed.
Description was changed from ========== [profiler] reduce incorrectly unaccounted ticks. No longer invalidate the tick sample if there is no JS frame or only one non-interpreted JS frame on the stack. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2799603005 Cr-Commit-Position: refs/heads/master@{#44465} Committed: https://chromium.googlesource.com/v8/v8/+/57bef9a1e2621555f70b9258593ae4a4235... ========== to ========== [profiler] reduce incorrectly unaccounted ticks. No longer invalidate the tick sample if there is no JS frame or only one non-interpreted JS frame on the stack. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2799603005 Cr-Commit-Position: refs/heads/master@{#44465} Committed: https://chromium.googlesource.com/v8/v8/+/57bef9a1e2621555f70b9258593ae4a4235... ==========
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org, cbruni@chromium.org Link to the patchset: https://codereview.chromium.org/2799603005/#ps80001 (title: "remove test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491557648919270,
"parent_rev": "d3e9aade0ff24e100621ab451e83f703439ace9e", "commit_rev":
"818c6d0ba9e92e3bb0557fabaad886f7cfd9ea8a"}
Message was sent while issue was closed.
Description was changed from ========== [profiler] reduce incorrectly unaccounted ticks. No longer invalidate the tick sample if there is no JS frame or only one non-interpreted JS frame on the stack. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2799603005 Cr-Commit-Position: refs/heads/master@{#44465} Committed: https://chromium.googlesource.com/v8/v8/+/57bef9a1e2621555f70b9258593ae4a4235... ========== to ========== [profiler] reduce incorrectly unaccounted ticks. No longer invalidate the tick sample if there is no JS frame or only one non-interpreted JS frame on the stack. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2799603005 Cr-Original-Commit-Position: refs/heads/master@{#44465} Committed: https://chromium.googlesource.com/v8/v8/+/57bef9a1e2621555f70b9258593ae4a4235... Review-Url: https://codereview.chromium.org/2799603005 Cr-Commit-Position: refs/heads/master@{#44478} Committed: https://chromium.googlesource.com/v8/v8/+/818c6d0ba9e92e3bb0557fabaad886f7cfd... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/v8/v8/+/818c6d0ba9e92e3bb0557fabaad886f7cfd... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
