Make HidConnection::Read reentrancy safe

Make HidConnection::Read reentrancy safe

This change makes it safe to call HidConnection::Read from within the
callback passed to a previous call to this method. On macOS and Linux
this means moving protected input report filtering to before the report
is queued. On Windows this wasn't an issue but filtered input reports
would cause a callback to never be executed.

BUG=None

Review-Url: https://codereview.chromium.org/2804313005
Cr-Commit-Position: refs/heads/master@{#463347}
Committed: https://chromium.googlesource.com/chromium/src/+/11eb9bf9995543cd1ff691dfa76303dc626e967a

[Reilly Grant (use Gerrit), 2017-04-07 21:27:03]

reillyg@chromium.org changed reviewers:
+ piperc@chromium.org

[Reilly Grant (use Gerrit), 2017-04-07 21:27:03]

This should fix your issue. Please take a look.

[Reilly Grant (use Gerrit), 2017-04-07 21:27:17]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:28:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:15:19]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-04-08 00:13:05]

More callback safety

[Reilly Grant (use Gerrit), 2017-04-08 00:13:13]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 00:13:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 01:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 01:03:11]

Dry run: This issue passed the CQ dry run.

[Casey Piper, 2017-04-09 03:51:19]

lgtm, no longer seeing crashes when reentering

[Reilly Grant (use Gerrit), 2017-04-10 07:33:15]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-04-10 07:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 07:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 07:33:34]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Reilly Grant (use Gerrit), 2017-04-10 17:49:27]

reillyg@chromium.org changed reviewers:
+ juncai@chromium.org

[Reilly Grant (use Gerrit), 2017-04-10 17:49:28]

Oops, I forgot that one needs to be a committer to approve changes. Jun, can you
take a look?

[juncai, 2017-04-10 17:58:40]

LGTM.

[Reilly Grant (use Gerrit), 2017-04-10 18:02:18]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-04-10 18:03:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:06:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 18:06:54]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Reilly Grant (use Gerrit), 2017-04-10 18:12:16]

Rebased.

[Reilly Grant (use Gerrit), 2017-04-10 18:12:37]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-04-10 18:12:37]

The patchset sent to the CQ was uploaded after l-g-t-m from piperc@chromium.org,
juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/2804313005/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-04-10 18:13:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:06:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491847957032970,
"parent_rev": "71618f5681772f3d76c8c9c1f7f24490074db4b3", "commit_rev":
"11eb9bf9995543cd1ff691dfa76303dc626e967a"}

[commit-bot: I haz the power, 2017-04-10 19:07:53]

Description was changed from

==========
Make HidConnection::Read reentrancy safe

This change makes it safe to call HidConnection::Read from within the
callback passed to a previous call to this method. On macOS and Linux
this means moving protected input report filtering to before the report
is queued. On Windows this wasn't an issue but filtered input reports
would cause a callback to never be executed.

BUG=None
==========

to

==========
Make HidConnection::Read reentrancy safe

This change makes it safe to call HidConnection::Read from within the
callback passed to a previous call to this method. On macOS and Linux
this means moving protected input report filtering to before the report
is queued. On Windows this wasn't an issue but filtered input reports
would cause a callback to never be executed.

BUG=None

Review-Url: https://codereview.chromium.org/2804313005
Cr-Commit-Position: refs/heads/master@{#463347}
Committed:
https://chromium.googlesource.com/chromium/src/+/11eb9bf9995543cd1ff691dfa763...
==========

[commit-bot: I haz the power, 2017-04-10 19:07:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/11eb9bf9995543cd1ff691dfa763...