Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: device/hid/hid_connection.h

Issue 2804313005: Make HidConnection::Read reentrancy safe (Closed)
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/hid/hid_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/hid/hid_connection.h
diff --git a/device/hid/hid_connection.h b/device/hid/hid_connection.h
index 1bf8d2e3c2d4f3bcad97dbd4562fac8376a3a1f9..dbff1caf093833c77baf1026bd5fdf46b2312036 100644
--- a/device/hid/hid_connection.h
+++ b/device/hid/hid_connection.h
@@ -75,18 +75,9 @@ class HidConnection : public base::RefCountedThreadSafe<HidConnection> {
size_t size,
const WriteCallback& callback) = 0;
- // PlatformRead implementation must call this method on read
- // success, rather than directly running the callback.
- // In case incoming buffer is empty or protected, it is filtered
- // and this method returns false. Otherwise it runs the callback
- // and returns true.
- bool CompleteRead(scoped_refptr<net::IOBuffer> buffer,
- size_t size,
- const ReadCallback& callback);
-
- private:
bool IsReportIdProtected(uint8_t report_id);
+ private:
scoped_refptr<HidDeviceInfo> device_info_;
bool has_protected_collection_;
base::ThreadChecker thread_checker_;
« no previous file with comments | « no previous file | device/hid/hid_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698