Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2804293002: Add MemberEntity.isAbstract and use MemberEntity in function_set.dart (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add MemberEntity.isAbstract and use MemberEntity in function_set.dart This makes function_set.dart reusable for kernel based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/77bd26f3d79e845361a1d6fef8a3da9ffb7269cb

Patch Set 1 #

Patch Set 2 : Inference doesn't like MemberEntity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -63 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 1 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 4 chunks +10 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 12 chunks +16 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 4 chunks +12 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 chunk +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 13 chunks +17 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-07 14:19:28 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-10 19:24:04 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-11 08:10:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
77bd26f3d79e845361a1d6fef8a3da9ffb7269cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698