Add MemberEntity.isAbstract and use MemberEntity in function_set.dart

pkg/compiler/lib/src/universe/function_set.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library universe.function_set;
 
 import '../common/names.dart' show Identifiers, Selectors;
-import '../elements/elements.dart' show MemberElement;
 import '../elements/entities.dart';
 import '../types/types.dart';
 import '../util/util.dart' show Hashing, Setlet;
 import '../world.dart' show ClosedWorld;
 import 'selector.dart' show Selector;
 import 'world_builder.dart' show ReceiverConstraint;
 
 class FunctionSetBuilder {
   final Map<String, FunctionSetNode> nodes = new Map<String, FunctionSetNode>();
 
   FunctionSetNode newNode(String name) => new FunctionSetNode(name);
 
-  void add(MemberElement element) {
+  void add(MemberEntity element) {
     assert(element.isInstanceMember);
     assert(!element.isAbstract);
     String name = element.name;
     FunctionSetNode node = nodes.putIfAbsent(name, () => newNode(name));
     node.add(element);
   }
 
-  void remove(MemberElement element) {
+  void remove(MemberEntity element) {
     assert(element.isInstanceMember);
     assert(!element.isAbstract);
     String name = element.name;
     FunctionSetNode node = nodes[name];
     if (node != null) {
       node.remove(element);
     }
   }
 
   FunctionSet close(ClosedWorld closedWorld) {
     return new FunctionSet(closedWorld, nodes);
   }
 }
 
 // TODO(kasperl): This actually holds getters and setters just fine
 // too and stricly they aren't functions. Maybe this needs a better
 // name -- something like ElementSet seems a bit too generic.
 class FunctionSet {
   final ClosedWorld closedWorld;
   final Map<String, FunctionSetNode> nodes;
 
   FunctionSet(this.closedWorld, this.nodes);
 
-  bool contains(MemberElement element) {
+  bool contains(MemberEntity element) {
     assert(element.isInstanceMember);
     assert(!element.isAbstract);
     String name = element.name;
     FunctionSetNode node = nodes[name];
     return (node != null) ? node.contains(element) : false;
   }
 
   /// Returns all the functions that may be invoked with the [selector] on a
   /// receiver with the given [constraint]. The returned elements may include
   /// noSuchMethod handlers that are potential targets indirectly through the
   /// noSuchMethod mechanism.
-  Iterable<MemberElement> filter(
+  Iterable<MemberEntity> filter(
       Selector selector, ReceiverConstraint constraint) {
     return query(selector, constraint).functions;
   }
 
   /// Returns the mask for the potential receivers of a dynamic call to
   /// [selector] on [constraint].
   ///
   /// This will narrow the constraints of [constraint] to a [TypeMask] of the
   /// set of classes that actually implement the selected member or implement
   /// the handling 'noSuchMethod' where the selected member is unimplemented.
@@ skipping 79 matching lines @@
 /// selectors with the same [name].
 class FunctionSetNode {
   final String name;
   final Map<SelectorMask, FunctionSetQuery> cache =
       <SelectorMask, FunctionSetQuery>{};
 
   // Initially, we keep the elements in a list because it is more
   // compact than a hash set. Once we get enough elements, we change
   // the representation to be a set to get faster contains checks.
   static const int MAX_ELEMENTS_IN_LIST = 8;
-  var elements = <MemberElement>[];
+  var elements = <MemberEntity>[];
   bool isList = true;
 
   FunctionSetNode(this.name);
 
-  void add(MemberElement element) {
+  void add(MemberEntity element) {
     assert(element.name == name);
     // We try to avoid clearing the cache unless we have to. For that
     // reason we keep the explicit contains check even though the add
     // method ends up doing the work again (for sets).
     if (!elements.contains(element)) {
       if (isList && elements.length >= MAX_ELEMENTS_IN_LIST) {
         elements = elements.toSet();
         isList = false;
       }
       elements.add(element);
       if (!cache.isEmpty) cache.clear();
     }
   }
 
-  void remove(MemberElement element) {
+  void remove(MemberEntity element) {
     assert(element.name == name);
     if (isList) {
       List list = elements;
       int index = list.indexOf(element);
       if (index < 0) return;
-      MemberElement last = list.removeLast();
+      MemberEntity last = list.removeLast();
       if (index != list.length) {
         list[index] = last;
       }
       if (!cache.isEmpty) cache.clear();
     } else {
       Set set = elements;
       if (set.remove(element)) {
         // To avoid wobbling between the two representations, we do
         // not transition back to the list representation even if we
         // end up with few enough elements at this point.
         if (!cache.isEmpty) cache.clear();
       }
     }
   }
 
-  bool contains(MemberElement element) {
+  bool contains(MemberEntity element) {
     assert(element.name == name);
     return elements.contains(element);
   }
 
   void forEach(Function action) {
     elements.forEach(action);
   }
 
   /// Returns the set of functions that can be the target of [selectorMask]
   /// including no such method handling where applicable.
   FunctionSetQuery query(SelectorMask selectorMask, ClosedWorld closedWorld,
       [FunctionSetNode noSuchMethods, SelectorMask noSuchMethodMask]) {
     assert(selectorMask.name == name);
     FunctionSetQuery result = cache[selectorMask];
     if (result != null) return result;
 
-    Setlet<MemberElement> functions;
-    for (MemberElement element in elements) {
+    Setlet<MemberEntity> functions;
+    for (MemberEntity element in elements) {
       if (selectorMask.applies(element, closedWorld)) {
         if (functions == null) {
           // Defer the allocation of the functions set until we are
           // sure we need it. This allows us to return immutable empty
           // lists when the filtering produced no results.
-          functions = new Setlet<MemberElement>();
+          functions = new Setlet<MemberEntity>();
         }
         functions.add(element);
       }
     }
 
     // If we cannot ensure a method will be found at runtime, we also
     // add [noSuchMethod] implementations that apply to [mask] as
     // potential targets.
     if (noSuchMethods != null &&
         selectorMask.needsNoSuchMethodHandling(closedWorld)) {
       FunctionSetQuery noSuchMethodQuery =
           noSuchMethods.query(noSuchMethodMask, closedWorld);
       if (!noSuchMethodQuery.functions.isEmpty) {
         if (functions == null) {
           functions =
-              new Setlet<MemberElement>.from(noSuchMethodQuery.functions);
+              new Setlet<MemberEntity>.from(noSuchMethodQuery.functions);
         } else {
           functions.addAll(noSuchMethodQuery.functions);
         }
       }
     }
     cache[selectorMask] = result = (functions != null)
         ? new FullFunctionSetQuery(functions)
         : const EmptyFunctionSetQuery();
     return result;
   }
 }
 
 /// A set of functions that are the potential targets of all call sites sharing
 /// the same receiver mask and selector.
 abstract class FunctionSetQuery {
   const FunctionSetQuery();
 
   /// Compute the type of all potential receivers of this function set.
   TypeMask computeMask(ClosedWorld closedWorld);
 
   /// Returns all potential targets of this function set.
-  Iterable<MemberElement> get functions;
+  Iterable<MemberEntity> get functions;
 }
 
 class EmptyFunctionSetQuery implements FunctionSetQuery {
   const EmptyFunctionSetQuery();
 
   @override
   TypeMask computeMask(ClosedWorld closedWorld) =>
       const TypeMask.nonNullEmpty();
 
   @override
-  Iterable<MemberElement> get functions => const <MemberElement>[];
+  Iterable<MemberEntity> get functions => const <MemberEntity>[];
 }
 
 class FullFunctionSetQuery implements FunctionSetQuery {
   @override
-  final Iterable<MemberElement> functions;
+  final Iterable<MemberEntity> functions;
 
   TypeMask _mask;
 
   FullFunctionSetQuery(this.functions);
 
   @override
   TypeMask computeMask(ClosedWorld closedWorld) {
     assert(closedWorld
         .hasAnyStrictSubclass(closedWorld.commonElements.objectClass));
     if (_mask != null) return _mask;
     return _mask = new TypeMask.unionOf(
-        functions.expand((MemberElement element) {
+        functions.expand((MemberEntity element) {
           ClassEntity cls = element.enclosingClass;
           return [cls]..addAll(closedWorld.mixinUsesOf(cls));
         }).map((cls) {
           if (closedWorld.backendClasses.nullClass == cls) {
             return const TypeMask.empty();
           } else if (closedWorld.isInstantiated(cls)) {
             return new TypeMask.nonNullSubclass(cls, closedWorld);
           } else {
             // TODO(johnniwinther): Avoid the need for this case.
             return const TypeMask.empty();
           }
         }),
         closedWorld);
   }
 }