Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: pkg/compiler/lib/src/inferrer/closure_tracer.dart

Issue 2804293002: Add MemberEntity.isAbstract and use MemberEntity in function_set.dart (Closed)
Patch Set: Inference doesn't like MemberEntity Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/inferrer_engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/closure_tracer.dart
diff --git a/pkg/compiler/lib/src/inferrer/closure_tracer.dart b/pkg/compiler/lib/src/inferrer/closure_tracer.dart
index cd76db6f4ff669ebec32a7b7fffc3b65da6a9f9e..83fc2fc78c90a491a64d82f05756097a1460e7aa 100644
--- a/pkg/compiler/lib/src/inferrer/closure_tracer.dart
+++ b/pkg/compiler/lib/src/inferrer/closure_tracer.dart
@@ -90,7 +90,8 @@ class ClosureTracerVisitor extends TracerVisitor {
// where `foo` is a getter.
_registerCallForLaterAnalysis(info);
}
- if (_checkIfFunctionApply(called) &&
+ if (called is MemberElement &&
+ _checkIfFunctionApply(called) &&
info.arguments != null &&
info.arguments.contains(currentUser)) {
_tagAsFunctionApplyTarget("static call");
@@ -100,9 +101,8 @@ class ClosureTracerVisitor extends TracerVisitor {
bool _checkIfCurrentUser(element) =>
inferrer.types.getInferredTypeOf(element) == currentUser;
- bool _checkIfFunctionApply(Element element) {
- return element is MemberElement &&
- compiler.commonElements.isFunctionApplyMethod(element);
+ bool _checkIfFunctionApply(MemberElement element) {
+ return compiler.commonElements.isFunctionApplyMethod(element);
}
@override
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/inferrer_engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698