Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2804283002: predictors: Refactor UpdateData() function. (Closed)

Created:
3 years, 8 months ago by alexilin
Modified:
3 years, 8 months ago
Reviewers:
Benoit L
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Refactor UpdateData() function. This CL splits UpdateData() function into UpdateResourceData() and UpdateRedirectData() with less number of arguments. ResourcePrefetchPredictor uses UpdateData() to update only one of the tables at the same time so there is no need to pass extra arguments each time. BUG=631966 Review-Url: https://codereview.chromium.org/2804283002 Cr-Commit-Position: refs/heads/master@{#464323} Committed: https://chromium.googlesource.com/chromium/src/+/6090964fb7c737742493816401a93ef120535875

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add a trace event for UpdateOrigin. #

Patch Set 4 : Oops fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -154 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 3 chunks +4 lines, -20 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.h View 1 2 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.cc View 1 2 3 2 chunks +38 lines, -52 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc View 1 6 chunks +18 lines, -24 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 14 chunks +28 lines, -50 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
alexilin
Hi lizeb, I wanted to do this refactoring for a long time. #(deleted lines) > ...
3 years, 8 months ago (2017-04-07 13:59:30 UTC) #2
Benoit L
That's cleaner this way, indeed, thanks. lgtm.
3 years, 8 months ago (2017-04-11 09:20:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804283002/60001
3 years, 8 months ago (2017-04-13 06:40:36 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 06:47:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6090964fb7c737742493816401a9...

Powered by Google App Engine
This is Rietveld 408576698