predictors: Refactor UpdateData() function.

chrome/browser/predictors/resource_prefetch_predictor_tables.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PREDICTORS_RESOURCE_PREFETCH_PREDICTOR_TABLES_H_
 #define CHROME_BROWSER_PREDICTORS_RESOURCE_PREFETCH_PREDICTOR_TABLES_H_
 
 #include <cstddef>
 #include <map>
 #include <memory>
@@ skipping 33 matching lines @@
   typedef std::map<std::string, OriginData> OriginDataMap;
 
   // Returns data for all Urls and Hosts.
   virtual void GetAllData(PrefetchDataMap* url_data_map,
                           PrefetchDataMap* host_data_map,
                           RedirectDataMap* url_redirect_data_map,
                           RedirectDataMap* host_redirect_data_map,
                           ManifestDataMap* manifest_map,
                           OriginDataMap* origin_data_map);
 
-  // Updates data for a Url and a host. If any of the arguments has an empty
-  // primary key, it will be ignored.
-  // Note that all the keys should be less |kMaxStringLength| in length.
-  virtual void UpdateData(const PrefetchData& url_data,
-                          const PrefetchData& host_data,
-                          const RedirectData& url_redirect_data,
-                          const RedirectData& host_redirect_data);
+  // Updates resource data for the input |data|.
+  // Note that the primary key in |data| should be less than |kMaxStringLength|
+  // in length.
+  virtual void UpdateResourceData(const PrefetchData& data,
+                                  PrefetchKeyType key_type);
+
+  // Updates redirect data for the input |data|.
+  // Note that the primary key in |data| should be less than |kMaxStringLength|
+  // in length.
+  virtual void UpdateRedirectData(const RedirectData& data,
+                                  PrefetchKeyType key_type);
 
   // Updates manifest data for the input |host|.
   virtual void UpdateManifestData(
       const std::string& host,
       const precache::PrecacheManifest& manifest_data);
 
   // Updates a given origin data point.
   virtual void UpdateOriginData(const OriginData& origin_data);
 
   // Delete data for the input |urls| and |hosts|.
@@ skipping 72 matching lines @@
 
   // Helper functions below help perform functions on the Url and host table
   // using the same code.
   void GetAllResourceDataHelper(PrefetchKeyType key_type,
                                 PrefetchDataMap* data_map);
   void GetAllRedirectDataHelper(PrefetchKeyType key_type,
                                 RedirectDataMap* redirect_map);
   void GetAllManifestDataHelper(ManifestDataMap* manifest_map);
   void GetAllOriginDataHelper(OriginDataMap* manifest_map);
 
-  bool UpdateDataHelper(PrefetchKeyType key_type,
+  void UpdateDataHelper(PrefetchKeyType key_type,
                         PrefetchDataType data_type,
                         const std::string& key,
                         const google::protobuf::MessageLite& data);
   void DeleteDataHelper(PrefetchKeyType key_type,
                         PrefetchDataType data_type,
                         const std::vector<std::string>& keys);
 
   // PredictorTableBase:
   void CreateTableIfNonExistent() override;
   void LogDatabaseStats() override;
@@ skipping 10 matching lines @@
 
   static const char* GetTableName(PrefetchKeyType key_type,
                                   PrefetchDataType data_type);
 
   DISALLOW_COPY_AND_ASSIGN(ResourcePrefetchPredictorTables);
 };
 
 }  // namespace predictors
 
 #endif  // CHROME_BROWSER_PREDICTORS_RESOURCE_PREFETCH_PREDICTOR_TABLES_H_