Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 2804143004: Add DeathTest suffix to blink_heap_unittests same thread check tests (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp
diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
index 4a0dfc79775daa31d0c00edfebd6bedd90553888..523357b54b608b0a082fe318ac41f9a620028d87 100644
--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp
+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
@@ -5369,7 +5369,7 @@ class MemberSameThreadCheckTester {
};
#if DCHECK_IS_ON()
-TEST(HeapTest, MemberSameThreadCheck) {
+TEST(HeapDeathTest, MemberSameThreadCheck) {
EXPECT_DEATH(MemberSameThreadCheckTester().test(), "");
}
#endif
@@ -5408,7 +5408,7 @@ class PersistentSameThreadCheckTester {
};
#if DCHECK_IS_ON()
-TEST(HeapTest, PersistentSameThreadCheck) {
+TEST(HeapDeathTest, PersistentSameThreadCheck) {
EXPECT_DEATH(PersistentSameThreadCheckTester().test(), "");
}
#endif
@@ -5458,7 +5458,7 @@ class MarkingSameThreadCheckTester {
};
#if DCHECK_IS_ON()
-TEST(HeapTest, MarkingSameThreadCheck) {
+TEST(HeapDeathTest, MarkingSameThreadCheck) {
// This will crash during marking, at the DCHECK in Visitor::markHeader() or
// earlier.
EXPECT_DEATH(MarkingSameThreadCheckTester().test(), "");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698