Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2804113005: Install delegates for preload Tab. (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 8 months ago
Reviewers:
kkhorimoto, sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Install delegates for preload Tab. Cherry picked remaining part from https://codereview.chromium.org/2759563003 uninstallDelegatesForTab does not exist on the branch and was not copied. BUG=707970 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2804113005 Cr-Commit-Position: refs/branch-heads/3029@{#635} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/817d8577b9790d3a0f3cbd2123446e5b2fcd577a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-07 02:16:49 UTC) #2
kkhorimoto
lgtm
3 years, 8 months ago (2017-04-07 21:55:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804113005/1
3 years, 8 months ago (2017-04-07 21:55:44 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-04-07 21:55:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804113005/1
3 years, 8 months ago (2017-04-07 21:58:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/817d8577b9790d3a0f3cbd2123446e5b2fcd577a
3 years, 8 months ago (2017-04-07 22:13:05 UTC) #14
sdefresne
3 years, 8 months ago (2017-04-10 09:54:21 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698