Display the preload Tab if it replaces the current Tab.

Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431
Review-Url: https://codereview.chromium.org/2759563003
Cr-Commit-Position: refs/heads/master@{#458100}
Committed: https://chromium.googlesource.com/chromium/src/+/fa0844ccdce295f9789664668f358d2df1a69b09

[kkhorimoto, 2017-03-17 20:51:47]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, sdefresne@chromium.org

[kkhorimoto, 2017-03-17 20:51:48]

It looks like after the WebStateList::ReplaceWebStateAt() changes behavior such
that BrowserViewController's |-tabSelected:| was no longer called.  I've updated
the replacement TabModelObserver function to display the new Tab if it replaces
the current Tab.

[Eugene But (OOO till 7-30), 2017-03-17 21:42:39]

This looks completely reasonable to me, so lgtm. But plese wait for Sylvain's
review (hopefully he understands this code better than me).

[sdefresne, 2017-03-20 14:12:57]

lgtm

[kkhorimoto, 2017-03-20 16:43:17]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-03-20 16:43:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2759563003/#ps20001
(title: "only display when active")

[commit-bot: I haz the power, 2017-03-20 16:43:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 17:01:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490028197575460,
"parent_rev": "c7a0947f9803da749b8f498252a5118e9b08d9ad", "commit_rev":
"fa0844ccdce295f9789664668f358d2df1a69b09"}

[commit-bot: I haz the power, 2017-03-20 17:02:11]

Description was changed from

==========
Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431
==========

to

==========
Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431

Review-Url: https://codereview.chromium.org/2759563003
Cr-Commit-Position: refs/heads/master@{#458100}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa0844ccdce295f9789664668f35...
==========

[commit-bot: I haz the power, 2017-03-20 17:02:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fa0844ccdce295f9789664668f35...