Chromium Code Reviews Chromium Code Reviews
Issue 2804093002:
Various page_load_metrics cleanups and improvements (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 86275e44d40e63364085c18179a18ec78aa33ecd..99b2e1a167dc0bf34217050336ad45b1d01b2c4d 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -46476,6 +46476,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="PageLoad.Internal.NavigationStartedInForeground" |
| + enum="Boolean"> |
|
Ilya Sherman
2017/04/08 01:14:59
nit: Could this be BooleanForeground with custom l
Bryan McQuade
2017/04/10 13:27:37
Done
|
| + <owner>bmcquade@chromium.org</owner> |
| + <summary>Whether a navigation started in the foreground.</summary> |
| +</histogram> |
| + |
| <histogram name="PageLoad.Internal.PageLoadCompleted.AfterAppBackground" |
| enum="BooleanStartedCompleted"> |
| <owner>bmcquade@chromium.org</owner> |
| @@ -46492,6 +46498,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="PageLoad.Internal.Prerender" enum="Boolean"> |
|
Ilya Sherman
2017/04/08 01:14:59
nit: Please use BooleanHit here.
Bryan McQuade
2017/04/10 13:27:37
Done
|
| + <owner>bmcquade@chromium.org</owner> |
| + <summary> |
| + Counts the number of prerender navigations. Only logs true values. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="PageLoad.Internal.ProvisionalAbortChainSize.ForwardBack" |
| units="length"> |
| <owner>csharrison@chromium.org</owner> |
| @@ -98906,7 +98919,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <enum name="InternalErrorLoadEvent" type="int"> |
| <summary>Internal Errors in the page_load_metrics system</summary> |
| - <int value="0" label="Invalid timing IPC sent from renderer"/> |
| + <int value="0" label="Invalid timing IPC sent from renderer (deprecated)"/> |
| <int value="1" |
| label="IPC received while not tracking a relevant committed load"/> |
| <int value="2" label="IPC received from a frame we navigated away from"/> |
| @@ -98922,6 +98935,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="9" label="No commit or failed provisional load received"/> |
| <int value="10" label="No page load end time recorded"/> |
| <int value="11" label="Timing IPC received from subframe"/> |
| + <int value="12" label="Invalid timing IPC (invalid timing descendent)"/> |
| + <int value="13" label="Invalid timing IPC (invalid behavior descendent)"/> |
| + <int value="14" label="Invalid timing IPC (invalid timing)"/> |
| </enum> |
| <enum name="InterruptReason" type="int"> |
