Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2804083004: Remove unneeded checks for finite coefficient values (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, haraken, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded checks for finite coefficient values The v8 bindings layer does the finite check for us so we don't have to check again. BUG=709061 TEST=covered by existing tests Review-Url: https://codereview.chromium.org/2804083004 Cr-Commit-Position: refs/heads/master@{#462956} Committed: https://chromium.googlesource.com/chromium/src/+/4efea4a5a7e3094b722f3454570b0f216101042d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-07 16:57:18 UTC) #2
hongchan
lgtm
3 years, 8 months ago (2017-04-07 17:08:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804083004/1
3 years, 8 months ago (2017-04-07 17:12:42 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 19:23:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4efea4a5a7e3094b722f3454570b...

Powered by Google App Engine
This is Rietveld 408576698