Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1920)

Unified Diff: third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp

Issue 2804083004: Remove unneeded checks for finite coefficient values (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp b/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp
index d8e5c2ed20de0550fcad33431d9c66c1cbb30e42..0c94207f05a6498761975a2718100596bcdfc644 100644
--- a/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp
@@ -88,29 +88,6 @@ IIRFilterNode* IIRFilterNode::create(BaseAudioContext& context,
return nullptr;
}
- // Make sure all coefficents are finite.
- for (size_t k = 0; k < feedforwardCoef.size(); ++k) {
- double c = feedforwardCoef[k];
- if (!std::isfinite(c)) {
- String name = "feedforward coefficient " + String::number(k);
- exceptionState.throwDOMException(
- InvalidStateError,
- ExceptionMessages::notAFiniteNumber(c, name.ascii().data()));
- return nullptr;
- }
- }
-
- for (size_t k = 0; k < feedbackCoef.size(); ++k) {
- double c = feedbackCoef[k];
- if (!std::isfinite(c)) {
- String name = "feedback coefficient " + String::number(k);
- exceptionState.throwDOMException(
- InvalidStateError,
- ExceptionMessages::notAFiniteNumber(c, name.ascii().data()));
- return nullptr;
- }
- }
-
return new IIRFilterNode(context, feedforwardCoef, feedbackCoef);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698