third_party/WebKit/Source/modules/fetch/Response.cpp - Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/Response.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/Response.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/Response.cpp b/third_party/WebKit/Source/modules/fetch/Response.cpp

index 204022b10170330c8eb623ebd17d04dec671eae7..e8234e2f31fa6c99aac11ec64fe325a0228beffe 100644

--- a/third_party/WebKit/Source/modules/fetch/Response.cpp

+++ b/third_party/WebKit/Source/modules/fetch/Response.cpp

@@ -88,7 +88,7 @@ FetchResponseData* createFetchResponseDataFromWebResponse(

case WebServiceWorkerResponseTypeDefault:

break;

case WebServiceWorkerResponseTypeError:

- ASSERT(response->getType() == FetchResponseData::ErrorType);

+ DCHECK(response->getType() == FetchResponseData::ErrorType);

tkent 2017/04/08 02:29:55 Use DCHECK_EQ if it doesn't cause a build failure.

break;

}