Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: third_party/WebKit/Source/modules/fetch/RequestTest.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/RequestTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/RequestTest.cpp b/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
index 0d32748914b45cb077d87d0b0b6988715da5e64c..aac36602a2657d3d54c855c13cd03d09efd280aa 100644
--- a/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
@@ -26,7 +26,7 @@ TEST(ServiceWorkerRequestTest, FromString) {
Request* request =
Request::create(scope.getScriptState(), url, exceptionState);
ASSERT_FALSE(exceptionState.hadException());
- ASSERT(request);
+ DCHECK(request);
EXPECT_EQ(url, request->url());
}
@@ -37,12 +37,12 @@ TEST(ServiceWorkerRequestTest, FromRequest) {
KURL url(ParsedURLString, "http://www.example.com/");
Request* request1 =
Request::create(scope.getScriptState(), url, exceptionState);
- ASSERT(request1);
+ DCHECK(request1);
Request* request2 =
Request::create(scope.getScriptState(), request1, exceptionState);
ASSERT_FALSE(exceptionState.hadException());
- ASSERT(request2);
+ DCHECK(request2);
EXPECT_EQ(url, request2->url());
}
@@ -73,7 +73,7 @@ TEST(ServiceWorkerRequestTest, FromAndToWebRequest) {
webRequest.setReferrer(referrer, referrerPolicy);
Request* request = Request::create(scope.getScriptState(), webRequest);
- ASSERT(request);
+ DCHECK(request);
EXPECT_EQ(url, request->url());
EXPECT_EQ(method, request->method());
EXPECT_EQ("audio", request->context());
@@ -111,7 +111,7 @@ TEST(ServiceWorkerRequestTest, ToWebRequestStripsURLFragment) {
String url = urlWithoutFragment + "#fragment";
Request* request =
Request::create(scope.getScriptState(), url, exceptionState);
- ASSERT(request);
+ DCHECK(request);
WebServiceWorkerRequest webRequest;
request->populateWebServiceWorkerRequest(webRequest);

Powered by Google App Engine
This is Rietveld 408576698