Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
index 4d79646b8b4888aedc6a279f347ac744feda7d4e..30d4569b6aa080cc614e9eb93c7b3a1955df30f7 100644
--- a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
@@ -61,7 +61,7 @@ TEST(ServiceWorkerResponseTest, FromFetchResponseData) {
urlList.push_back(url);
fetchResponseData->setURLList(urlList);
Response* response = Response::create(&page->document(), fetchResponseData);
- ASSERT(response);
+ DCHECK(response);
EXPECT_EQ(url, response->url());
}
@@ -70,7 +70,7 @@ TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponse) {
std::unique_ptr<WebServiceWorkerResponse> webResponse =
createTestWebServiceWorkerResponse();
Response* response = Response::create(scope.getScriptState(), *webResponse);
- ASSERT(response);
+ DCHECK(response);
ASSERT_EQ(1u, webResponse->urlList().size());
EXPECT_EQ(webResponse->urlList()[0], response->url());
EXPECT_EQ(webResponse->status(), response->status());

Powered by Google App Engine
This is Rietveld 408576698