Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/modules/fetch/Request.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/Request.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/Request.cpp b/third_party/WebKit/Source/modules/fetch/Request.cpp
index 14ad2a628526cc19a14d0c0cd522d9c4bd32a0e2..12bc5c3cc62775b464df22ac0cbef9e86205e548 100644
--- a/third_party/WebKit/Source/modules/fetch/Request.cpp
+++ b/third_party/WebKit/Source/modules/fetch/Request.cpp
@@ -332,12 +332,12 @@ Request* Request::createRequestWithRequestOrString(
}
// "Fill |r|'s Headers object with |headers|. Rethrow any exceptions."
if (init.headers) {
- ASSERT(init.headersDictionary.isUndefinedOrNull());
+ DCHECK(init.headersDictionary.isUndefinedOrNull());
r->getHeaders()->fillWith(init.headers.get(), exceptionState);
} else if (!init.headersDictionary.isUndefinedOrNull()) {
r->getHeaders()->fillWith(init.headersDictionary, exceptionState);
} else {
- ASSERT(headers);
+ DCHECK(headers);
r->getHeaders()->fillWith(headers, exceptionState);
}
if (exceptionState.hadException())
@@ -426,7 +426,7 @@ Request* Request::create(ScriptState* scriptState,
const RequestInfo& input,
const Dictionary& init,
ExceptionState& exceptionState) {
- ASSERT(!input.isNull());
+ DCHECK(!input.isNull());
if (input.isUSVString())
return create(scriptState, input.getAsUSVString(), init, exceptionState);
return create(scriptState, input.getAsRequest(), init, exceptionState);
@@ -577,8 +577,8 @@ String Request::referrer() const {
// "The referrer attribute's getter must return the empty string if
// request's referrer is no referrer, "about:client" if request's referrer
// is client and request's referrer, serialized, otherwise."
- ASSERT(FetchRequestData::noReferrerString() == AtomicString());
- ASSERT(FetchRequestData::clientReferrerString() ==
+ DCHECK(FetchRequestData::noReferrerString() == AtomicString());
tkent 2017/04/08 02:29:54 Use DCHECK_EQ if it doesn't cause a build failure.
+ DCHECK(FetchRequestData::clientReferrerString() ==
tkent 2017/04/08 02:29:54 Use DCHECK_EQ if it doesn't cause a build failure.
AtomicString("about:client"));
return m_request->referrerString();
}
@@ -598,7 +598,7 @@ String Request::getReferrerPolicy() const {
case ReferrerPolicyOriginWhenCrossOrigin:
return "origin-when-cross-origin";
case ReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin:
- ASSERT(RuntimeEnabledFeatures::reducedReferrerGranularityEnabled());
+ DCHECK(RuntimeEnabledFeatures::reducedReferrerGranularityEnabled());
return "no-referrer-when-downgrade-origin-when-cross-origin";
}
ASSERT_NOT_REACHED();
@@ -674,7 +674,7 @@ Request* Request::clone(ScriptState* scriptState,
}
FetchRequestData* Request::passRequestData(ScriptState* scriptState) {
- ASSERT(!bodyUsed());
+ DCHECK(!bodyUsed());
FetchRequestData* data = m_request->pass(scriptState);
refreshBody(scriptState);
// |data|'s buffer('s js wrapper) has no retainer, but it's OK because

Powered by Google App Engine
This is Rietveld 408576698