Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2804023003: Network traffic annotation added to chrome/browser/ unittests. (Closed)

Created:
3 years, 8 months ago by Ramin Halavati
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, vakh+watch_chromium.org, tburkard+watch_chromium.org, grt+watch_chromium.org, donnd+watch_chromium.org, Randy Smith (Not in Mondays), timvolodine, net-reviews_chromium.org, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, David Black, Jered, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, mmenke, battre, msramek
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network traffic annotation added to chrome/browser/ unittests. Test Network traffic annotation tag is added to network requests of unittest in chrome/browser/*. BUG=656607 Review-Url: https://codereview.chromium.org/2804023003 Cr-Commit-Position: refs/heads/master@{#462947} Committed: https://chromium.googlesource.com/chromium/src/+/04b9338b15bb938550a0bc904ee769a2d73cdfe3

Patch Set 1 #

Patch Set 2 : Missing headers added. #

Patch Set 3 : Another missing header added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -77 lines) Patch
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/data_usage/tab_id_annotator_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 1 2 9 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 9 chunks +20 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc View 1 7 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 10 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/net/safe_search_util_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/chrome_data_use_group_provider_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/net/spdyproxy/chrome_data_use_group_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_resource_throttle_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search/iframe_source_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 22 (17 generated)
Ramin Halavati
I've added test network annotation tags to unittests of chrome/browser. Network requests created for test ...
3 years, 8 months ago (2017-04-07 14:02:29 UTC) #14
Ramin Halavati
I've added test network annotation tags to unittests of chrome/browser. Network requests created for test ...
3 years, 8 months ago (2017-04-07 14:02:32 UTC) #15
Lei Zhang
lgtm I fixed a typo in the CL description.
3 years, 8 months ago (2017-04-07 18:52:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804023003/40001
3 years, 8 months ago (2017-04-07 18:53:08 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 19:01:53 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/04b9338b15bb938550a0bc904ee7...

Powered by Google App Engine
This is Rietveld 408576698