chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc - Issue 2804023003: Network traffic annotation added to chrome/browser/ unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc

Issue 2804023003: Network traffic annotation added to chrome/browser/ unittests. (Closed)

Patch Set: Another missing header added. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/user_script_listener_unittest.cc ('k') | chrome/browser/net/chrome_network_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc

diff --git a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc

index 313f5f4cfe849e9ebc619e87577eea29a78de5bd..b43dc638a87264d8ed9850d78f2038edf9cc3706 100644

--- a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc

+++ b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc

@@ -14,6 +14,7 @@

#include "content/public/browser/navigation_data.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "net/base/request_priority.h"

+#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"

#include "net/url_request/url_request.h"

#include "net/url_request/url_request_context.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -37,8 +38,9 @@ class ChromeResourceDispatcherHostDelegateTest : public testing::Test {

TEST_F(ChromeResourceDispatcherHostDelegateTest,

GetNavigationDataWithDataReductionProxyData) {

std::unique_ptr<net::URLRequestContext> context(new net::URLRequestContext());

- std::unique_ptr<net::URLRequest> fake_request(context->CreateRequest(

- GURL("google.com"), net::RequestPriority::IDLE, nullptr));

+ std::unique_ptr<net::URLRequest> fake_request(

+ context->CreateRequest(GURL("google.com"), net::RequestPriority::IDLE,

+ nullptr, TRAFFIC_ANNOTATION_FOR_TESTS));

// Add DataReductionProxyData to URLRequest

data_reduction_proxy::DataReductionProxyData* data_reduction_proxy_data =

data_reduction_proxy::DataReductionProxyData::GetDataAndCreateIfNecessary(

@@ -63,8 +65,9 @@ TEST_F(ChromeResourceDispatcherHostDelegateTest,

TEST_F(ChromeResourceDispatcherHostDelegateTest,

GetNavigationDataWithoutDataReductionProxyData) {

std::unique_ptr<net::URLRequestContext> context(new net::URLRequestContext());

- std::unique_ptr<net::URLRequest> fake_request(context->CreateRequest(

- GURL("google.com"), net::RequestPriority::IDLE, nullptr));

+ std::unique_ptr<net::URLRequest> fake_request(

+ context->CreateRequest(GURL("google.com"), net::RequestPriority::IDLE,

+ nullptr, TRAFFIC_ANNOTATION_FOR_TESTS));

std::unique_ptr<ChromeResourceDispatcherHostDelegate> delegate(

new ChromeResourceDispatcherHostDelegate());

ChromeNavigationData* chrome_navigation_data =