Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2803943006: Re-enable css-align-3 tests from WPT repository (Closed)

Created:
3 years, 8 months ago by Manuel Rego
Modified:
3 years, 8 months ago
Reviewers:
jfernandez, qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable css-align-3 tests from WPT repository BUG=706118 Review-Url: https://codereview.chromium.org/2803943006 Cr-Commit-Position: refs/heads/master@{#462875} Committed: https://chromium.googlesource.com/chromium/src/+/311b4ebadca3e47753627f385ee4ce3482331404

Patch Set 1 #

Patch Set 2 : Rebased patch removing some more tests from TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Manuel Rego
One more CL to enable css-align-3 this time. Since they were disabled, a new test ...
3 years, 8 months ago (2017-04-07 08:50:32 UTC) #3
jfernandez
lgtm
3 years, 8 months ago (2017-04-07 08:56:41 UTC) #4
Manuel Rego
Support for place-self is landing so I'll rebase this once that lands as probably more ...
3 years, 8 months ago (2017-04-07 10:30:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803943006/20001
3 years, 8 months ago (2017-04-07 14:42:19 UTC) #8
qyearsley
lgtm, thanks!
3 years, 8 months ago (2017-04-07 15:51:45 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:59:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/311b4ebadca3e47753627f385ee4...

Powered by Google App Engine
This is Rietveld 408576698