Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2804623002: [css-align] Implement place-self alignment shorthand (Closed)

Created:
3 years, 8 months ago by jfernandez
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, blink-reviews-frames_chromium.org, rwlbuis, Bugs Nash
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-align] Implement place-self alignment shorthand The CSS Box Alignment specification defines a new shorthand to set the Self Alignment properties (align-self and justify-self) at the same time. This patch provides the implementation of the CSS parsing logic and the required regression tests. For the time being, as it happens with the rest of the new alignment properties, the new parsing logic is implemented behind the CSS Grid Layout runtime flag. The intent-to-implement-and-ship of CSS Box Alignment shorthands is: https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/qCfsZJhGtOQ BUG=668639 Review-Url: https://codereview.chromium.org/2804623002 Cr-Commit-Position: refs/heads/master@{#462842} Committed: https://chromium.googlesource.com/chromium/src/+/d332296ceffaf87939123159cb58d12dea283c27

Patch Set 1 #

Patch Set 2 : Patch rebased for landing #

Patch Set 3 : Fixed layout tests. #

Patch Set 4 : Added a regression test. #

Messages

Total messages: 22 (13 generated)
jfernandez
PTAL
3 years, 8 months ago (2017-04-05 12:08:00 UTC) #3
Rick Byers
On 2017/04/05 12:08:00, jfernandez wrote: > PTAL UseCounter LGTM But I don't have much expertise ...
3 years, 8 months ago (2017-04-05 18:25:19 UTC) #6
meade_UTC10
core/css lgtm Added bugsnash@ to cc as FYI
3 years, 8 months ago (2017-04-06 03:36:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804623002/1
3 years, 8 months ago (2017-04-07 08:57:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/71266) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-07 09:00:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804623002/20001
3 years, 8 months ago (2017-04-07 09:12:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/424549)
3 years, 8 months ago (2017-04-07 10:13:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804623002/60001
3 years, 8 months ago (2017-04-07 10:24:27 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 12:10:55 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d332296ceffaf87939123159cb58...

Powered by Google App Engine
This is Rietveld 408576698