Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2803943005: Fix crash on startup if you hit back before native. (Closed)

Created:
3 years, 8 months ago by Ted C
Modified:
3 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash on startup if you hit back before native. We are attempting to log metrics before native is initialized. BUG=706400 Review-Url: https://codereview.chromium.org/2803943005 Cr-Commit-Position: refs/heads/master@{#462724} Committed: https://chromium.googlesource.com/chromium/src/+/87f32deba6f0a1a629f55d3a57d4d52cba412427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 8 months ago (2017-04-07 00:04:40 UTC) #2
gone
lgtm
3 years, 8 months ago (2017-04-07 00:05:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803943005/1
3 years, 8 months ago (2017-04-07 00:06:06 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 01:09:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/87f32deba6f0a1a629f55d3a57d4...

Powered by Google App Engine
This is Rietveld 408576698