chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2803943005: Fix crash on startup if you hit back before native.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2803943005: Fix crash on startup if you hit back before native. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index 09a944757b1ac66dc73c7019444a86bf345a3e64..6df787447f7c83a3ce00838e788f5bd99c77d202 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -1755,7 +1755,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

@Override

public final void onBackPressed() {

- RecordUserAction.record("SystemBack");

+ if (mNativeInitialized) RecordUserAction.record("SystemBack");

if (VrShellDelegate.onBackPressed()) return;

if (mCompositorViewHolder != null) {

LayoutManager layoutManager = mCompositorViewHolder.getLayoutManager();

« no previous file with comments | « no previous file | no next file » | no next file with comments »